Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: fix performance regression #39254

Closed
wants to merge 1 commit into from
Closed

stream: fix performance regression #39254

wants to merge 1 commit into from

Conversation

mscdex
Copy link
Contributor

@mscdex mscdex commented Jul 4, 2021

Benchmark result:

                                              confidence improvement accuracy (*)   (**)  (***)
streams/creation.js kind='duplex' n=50000000        ***     25.65 %       ±2.49% ±3.34% ±4.41%

@mscdex mscdex added stream Issues and PRs related to the stream subsystem. performance Issues and PRs related to the performance of Node.js. labels Jul 4, 2021
@github-actions github-actions bot added the needs-ci PRs that need a full CI run. label Jul 4, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@mscdex mscdex force-pushed the streams-fix-perf-regression branch from 3e5aa92 to a1ee30b Compare July 4, 2021 11:20
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38844/

@mscdex mscdex removed the needs-ci PRs that need a full CI run. label Jul 4, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38894/

@ronag
Copy link
Member

ronag commented Jul 8, 2021

Landed in a5ba28d

@ronag ronag closed this Jul 8, 2021
ronag pushed a commit that referenced this pull request Jul 8, 2021
@mscdex @ronag
stream: fix performance regression
a5ba28d 
PR-URL: #39254
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@mscdex mscdex deleted the streams-fix-perf-regression branch July 8, 2021 12:02
@BethGriggs BethGriggs mentioned this pull request Oct 14, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZYSzys ZYSzys ZYSzys approved these changes

@aduh95 aduh95 aduh95 approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
performance Issues and PRs related to the performance of Node.js. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@mscdex @nodejs-github-bot @ronag @jasnell @lpinca @cjihrig @aduh95 @ZYSzys @targos